feat: Replace columnHasNulls with row stats #11841
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
zation99
changed the title
zation99
changed the title
xiaoxmeng
reviewed
Dec 13, 2024
| @@ -823,7 +823,8 @@ class RowContainer { | |||
|
|
|||
| /// Returns true if specified column may have nulls, false otherwise. | |||
| inline bool columnHasNulls(int32_t columnIndex) const { | |||
| return columnHasNulls_[columnIndex]; | |||
| return columnStats(columnIndex).has_value() && | |||
There was a problem hiding this comment.
s/columnHasNulls/columnMayHaveNulls/
!columnStats(columnIndex).has_value() || columnStats(columnIndex)->nullCount() > 0?
There was a problem hiding this comment.
As @tanjialiang suggested, I'll separate the nullCount when invalidating columnStats, so that we don't need to check it here.
zhli1142015
reviewed
Dec 13, 2024
| @@ -567,7 +562,8 @@ void RowContainer::store( | |||
| decoded, | |||
| rows, | |||
| isKey, | |||
| offsets_[column]); | |||
| offsets_[column], | |||
| column); | |||
There was a problem hiding this comment.
This is also change in #11527, FYI.
Thanks.
There was a problem hiding this comment.
Thanks for the information. I see it's already merged. Let me rebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to address #11741
In the case of erasure, columnStats is invalidated so optimizations for hasNull is turned off.